Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream browser dialog refactoring #788

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Stream browser dialog refactoring #788

merged 8 commits into from
Oct 25, 2024

Conversation

fredzo
Copy link
Contributor

@fredzo fredzo commented Oct 22, 2024

Hi Andrew,

Here are the changes discussed on Discord for StreamBrowserDialog:

  • Refactored the DoRender() method in several parts + removed lambda for easier maintenance
  • Made vertical range unit for Oscilloscope stream dynamic (using actual stream unit
  • Made Instrument state badge latched to prevent flashing + made the latch duration configurable in preferences

Best,

Frederic.

@azonenberg azonenberg merged commit 0d64c1a into ngscopeclient:master Oct 25, 2024
@azonenberg azonenberg mentioned this pull request Oct 26, 2024
Closed
@fredzo fredzo deleted the stream-browser-dialog-refactoring branch November 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredzo @azonenberg